Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(plugin-js): move env to plugin method params #1614

Merged
merged 16 commits into from
Mar 15, 2023
Merged

refactor(plugin-js): move env to plugin method params #1614

merged 16 commits into from
Mar 15, 2023

Conversation

Niraj-Kamdar
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar commented Mar 9, 2023 •
edited by dOrgJelli
Loading

closes: #1563

@dOrgJelli dOrgJelli requested a review from pileks as a code owner March 15, 2023 17:31
@dOrgJelli dOrgJelli merged commit 7833bcd into origin-dev Mar 15, 2023
@dOrgJelli dOrgJelli deleted the nk/refactor-env-plugin-ts branch April 10, 2023 16:55
@dOrgJelli dOrgJelli mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@nerfZael nerfZael Awaiting requested review from nerfZael

@krisbitney krisbitney Awaiting requested review from krisbitney

@cbrzn cbrzn Awaiting requested review from cbrzn

@namesty namesty Awaiting requested review from namesty namesty is a code owner

@pileks pileks Awaiting requested review from pileks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin-ts bindings should expose env as a function argument
2 participants
@Niraj-Kamdar @dOrgJelli