Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of polywrap.yaml fails when abi import has an @ in the path #1341

Closed
fetsorn opened this issue Oct 18, 2022 · 0 comments · Fixed by #1342
Closed

Validation of polywrap.yaml fails when abi import has an @ in the path #1341

fetsorn opened this issue Oct 18, 2022 · 0 comments · Fixed by #1342
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@fetsorn
Copy link
Contributor

fetsorn commented Oct 18, 2022

Describe the bug
Polywrap failed validation of polywrap.yaml when I set import_abis[0].abi path to "./node_modules/@fetsorn/package".
The error seems to occur only when the "at sign", "@" is in the path. If I alias the package to "./node_modules/package", the validation succeeds.
The error said that the path doesn't match the pattern. The same schema and pattern correctly validate a json file with such path, so perhaps the issue is caused by yaml parsing.

Please provide the steps to reproduce and if possible a minimal demo of the problem.
Open any project and add import_abis to polywrap.yaml with a path to "./node_modules/@user/package".

Expected behavior
abi resolves correctly when path has an "at sign", "@".

Relevant environment details:

  • linux x64, polywrap 0.9.2
@fetsorn fetsorn added the type: bug Something isn't working label Oct 18, 2022
@dOrgJelli dOrgJelli linked a pull request Oct 18, 2022 that will close this issue
@dOrgJelli dOrgJelli self-assigned this Oct 18, 2022
@dOrgJelli dOrgJelli added this to the origin-qa milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants