Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Run (Test) Command Exits W/O Error When Wrapper Not Found #1358

Closed
dOrgJelli opened this issue Oct 21, 2022 · 3 comments · Fixed by #1610
Closed

CLI: Run (Test) Command Exits W/O Error When Wrapper Not Found #1358

dOrgJelli opened this issue Oct 21, 2022 · 3 comments · Fixed by #1610
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@dOrgJelli
Copy link
Contributor

Describe the bug
When a polywrap run loads a polywrap.test.yaml manifest that includes a wrapper URI that is not resolvable (doesn't exist), the command seems to exit prematurely w/o any error message.

Please provide the steps to reproduce and if possible a minimal demo of the problem.

  • Clone the toolchain repo
  • Build packages (so CLI is present)
  • cd ./packages/test-cases/cases/cli/run/001-yaml-workflow/
  • make sure ./packages/test-cases/cases/cli/run/run-test-wrapper/build doesn't exist
  • run ../../../../../cli/bin/polywrap run
  • The command exits w/o any error:
001-yaml-workflow % ../../../../../cli/bin/polywrap run
🔄 Manifest loaded from ./polywrap.test.yaml
✅ Manifest loaded from ./polywrap.test.yaml

If you now go and build the run-test-wrapper wrapper, the run command will succeed.

Expected behavior
There should be an error stating that the wrapper cannot be found.

Relevant environment details:

  • CLI Version: 0.9.3
@dOrgJelli dOrgJelli added the type: bug Something isn't working label Oct 21, 2022
@dOrgJelli dOrgJelli added this to the origin-qa milestone Oct 21, 2022
@krisbitney krisbitney self-assigned this Oct 28, 2022
@krisbitney
Copy link
Contributor

krisbitney commented Oct 28, 2022

I tried to reproduce the error on the origin-dev branch and I got this output. What do you think?

Screen Shot 2022-10-28 at 2 24 08 PM

Screen Shot 2022-10-28 at 2 27 11 PM

@krisbitney krisbitney removed their assignment Feb 7, 2023
@dOrgJelli
Copy link
Contributor Author

@krisbitney does this result in an exit code of non-zero?

@krisbitney
Copy link
Contributor

@krisbitney does this result in an exit code of non-zero?

I looked into it and it doesn't, no.

Each step of each job is a distinct invocation. Some can fail while others succeed. So it makes sense that it works this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants