Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build-Time Improvement: Don't Overwrite Build Image Cache #616

Closed
dOrgJelli opened this issue Jan 20, 2022 · 1 comment · Fixed by #678
Closed

Build-Time Improvement: Don't Overwrite Build Image Cache #616

dOrgJelli opened this issue Jan 20, 2022 · 1 comment · Fixed by #678
Assignees
Labels

Comments

@dOrgJelli
Copy link
Contributor

Currently by default, the CLI assigns a single name to the docker build-image it constructs.

This causes a loss of caching when building 2 separate projects back to back, this is because the name is being re-used for two different project directories. The cache gets flushed because the source files are different in the project directory.

In order to fix this, we should prescribe a name to the build image. This image name can be found by:

  • Looking at the build manifest's docker.name property
  • Allowing the user to assign it via a command line argument
  • Auto generating a random name

The build image's name can be cached in the CLI's .w3/ archive folder.

@dOrgJelli dOrgJelli added difficulty: easy Good for newcomers pri: mid labels Jan 20, 2022
@Niraj-Kamdar
Copy link
Contributor

This would be really nice improvement for devs! I also noticed some issues due to it having same name in docker networks, apparently I need to prune docker network sometimes since it creates to network with the same name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants