Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Concerns, IPFS/ENS Plugins, URI Resolver Interface #622

Closed
Tracked by #714
dOrgJelli opened this issue Jan 25, 2022 · 5 comments · Fixed by #912
Closed
Tracked by #714

Separate Concerns, IPFS/ENS Plugins, URI Resolver Interface #622

dOrgJelli opened this issue Jan 25, 2022 · 5 comments · Fixed by #912
Assignees
Labels
Milestone

Comments

@dOrgJelli
Copy link
Contributor

With the IPFS & ENS plugins, they both implement their respective core functionalities, along with implementing the URI Resolver interface methods.

This causes a "confusion of concerns", and leads to issues like the ones described in this thread: https://discord.com/channels/796821176743362611/908544308876050515/935542806418710548

We should create separate plugins for the IPFS & ENS URI-Resolvers, which depend on the IPFS & ENS wrappers within themselves.

@dOrgJelli dOrgJelli added difficulty: easy Good for newcomers pri: mid labels Jan 25, 2022
@nerfZael
Copy link
Contributor

nerfZael commented Mar 3, 2022

With the IPFS & ENS plugins, they both implement their respective core functionalities, along with implementing the URI Resolver interface methods.

This causes a "confusion of concerns", and leads to issues like the ones described in this thread: https://discord.com/channels/796821176743362611/908544308876050515/935542806418710548

We should create separate plugins for the IPFS & ENS URI-Resolvers, which depend on the IPFS & ENS wrappers within themselves.

They will depend on IPFS plugin and ENS wrapper, correct? @dOrgJelli
Also, we need to add the FS URI Resolver to this list

@nerfZael
Copy link
Contributor

nerfZael commented Mar 3, 2022

Added this to the following story: #714

@nerfZael nerfZael added this to the alpha milestone Mar 15, 2022
@evanjacobs evanjacobs removed this from the alpha milestone Mar 17, 2022
@dOrgJelli dOrgJelli added this to the alpha milestone Mar 29, 2022
@nerfZael
Copy link
Contributor

nerfZael commented Apr 6, 2022

IPFS part is blocking: #717

@nerfZael
Copy link
Contributor

nerfZael commented Apr 12, 2022

Before this is tackled we should merge this PR:

@dOrgJelli
Copy link
Contributor Author

@nerfZael new plugin devexp has been merged, and will be in versions 0.0.1-prealpha.72+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants