-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Concerns, IPFS/ENS Plugins, URI Resolver Interface #622
Comments
They will depend on IPFS plugin and ENS wrapper, correct? @dOrgJelli |
Added this to the following story: #714 |
IPFS part is blocking: #717 |
Before this is tackled we should merge this PR:
|
@nerfZael new plugin devexp has been merged, and will be in versions |
With the IPFS & ENS plugins, they both implement their respective core functionalities, along with implementing the URI Resolver interface methods.
This causes a "confusion of concerns", and leads to issues like the ones described in this thread: https://discord.com/channels/796821176743362611/908544308876050515/935542806418710548
We should create separate plugins for the IPFS & ENS URI-Resolvers, which depend on the IPFS & ENS wrappers within themselves.
The text was updated successfully, but these errors were encountered: