Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tests that evaluate stdout output #138

Open
hasheddan opened this issue Jun 15, 2020 · 5 comments
Open

Replace tests that evaluate stdout output #138

hasheddan opened this issue Jun 15, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@hasheddan
Copy link
Member

Some of the integration tests evaluate that certain words are present in the stdout output, which can break or change with updates to the logging verbosity. The following tests specifically do this:

integration/update/empty-deps                                                                                                                                                     
integration/update/github-leaf                                                                                                                                                                 
integration/fetch/empty-deps
integration/fetch/local-direct
integration/fetch/mutually-recursive
integration/fetch/self-referential
integration/fetch/local-git                                                                                                                                                                       
integration/fetch/github-deep                                                                                                                                                                  
integration/fetch/remote-gits
integration/help
integration/info
integration/run
integration/run/without-bundle
integration/version

See #137 for more information.

@SeanTAllen would you like for these checks to just be removed from all of these tests? In help / info / version we would essentially just be testing exit 0.

@SeanTAllen
Copy link
Member

I'd like to replace the tests that are using output to determine if an action happened with creating tests that use test-doubles to verify the correction interactions like for example, these that I recently wrote:

https://github.com/ponylang/corral/pull/132/files
https://github.com/ponylang/corral/pull/134/files

@hasheddan
Copy link
Member Author

Did some work on this today, learned a bunch from this commit (7f00b2b). Hoping to have some updates landing soon 👍

@SeanTAllen SeanTAllen added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 16, 2020
@SeanTAllen
Copy link
Member

@hasheddan are you interested in working on this? if yes, i can add you as a "contributor" to the ponylang org which basically allows you to be assigned to issues and not much else, then I can assign you to this.

@hasheddan
Copy link
Member Author

@SeanTAllen Definitely! Thanks 👍

@SeanTAllen
Copy link
Member

ok @hasheddan once you accept the invite, you should be able to assign yourself as you will have "triage" level access to all the organization repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants