Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some default web favicons not loading properly #96

Closed
jacobgkau opened this issue Mar 28, 2022 · 0 comments · Fixed by #97
Closed

Some default web favicons not loading properly #96

jacobgkau opened this issue Mar 28, 2022 · 0 comments · Fixed by #97

Comments

@jacobgkau
Copy link
Member

jacobgkau commented Mar 28, 2022

The Amazon and Crates.io icons loaded properly as of #42, and still show up on my main work machine where they're cached:

Screenshot from 2022-03-28 11-18-38
Screenshot from 2022-03-28 11-18-40

However, on a fresh machine/fresh account without a cache, they're currently showing the Google API's default icon for when a website doesn't have a favicon:

Screenshot from 2022-03-28 11-19-42
Screenshot from 2022-03-28 11-19-46

This happens on d17acbd (not caused by #95, but still happening there too as of right now.)

Worth noting that it's possible something changed on the Google API's end, or else something changed between #42 and now that was missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant