Skip to content

Commit eecbf13

Browse files
superm1crawfxrd
authored andcommitted
ACPI: PM: s2idle: Invert Microsoft UUID entry and exit
It was reported by a user with a Dell m15 R5 (5800H) that the keyboard backlight was turning on when entering suspend and turning off when exiting (the opposite of how it should be). The user bisected it back to commit 5dbf509 ("ACPI: PM: s2idle: Add support for new Microsoft UUID"). Previous to that commit the LEDs didn't turn off at all. Confirming in the spec, these were reversed when introduced. Fix them to match the spec. BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1230#note_1021836 Fixes: 5dbf509 ("ACPI: PM: s2idle: Add support for new Microsoft UUID") Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
1 parent 04c243b commit eecbf13

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/acpi/x86/s2idle.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ int acpi_s2idle_prepare_late(void)
446446
if (lps0_dsm_func_mask_microsoft > 0) {
447447
acpi_sleep_run_lps0_dsm(ACPI_LPS0_SCREEN_OFF,
448448
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
449-
acpi_sleep_run_lps0_dsm(ACPI_LPS0_MS_EXIT,
449+
acpi_sleep_run_lps0_dsm(ACPI_LPS0_MS_ENTRY,
450450
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
451451
acpi_sleep_run_lps0_dsm(ACPI_LPS0_ENTRY,
452452
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
@@ -473,7 +473,7 @@ void acpi_s2idle_restore_early(void)
473473
if (lps0_dsm_func_mask_microsoft > 0) {
474474
acpi_sleep_run_lps0_dsm(ACPI_LPS0_EXIT,
475475
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
476-
acpi_sleep_run_lps0_dsm(ACPI_LPS0_MS_ENTRY,
476+
acpi_sleep_run_lps0_dsm(ACPI_LPS0_MS_EXIT,
477477
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
478478
acpi_sleep_run_lps0_dsm(ACPI_LPS0_SCREEN_ON,
479479
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);

0 commit comments

Comments
 (0)