Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Reduce AMD Hotplug detection CPU usage with memmap #361

Closed
wants to merge 1 commit into from
Closed

perf: Reduce AMD Hotplug detection CPU usage with memmap #361

wants to merge 1 commit into from

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Sep 16, 2022

May fix #360

Needs testing to ensure display hotplug detection still works with AMD integrated graphics laptops.

@mmstick mmstick requested review from a team September 16, 2022 17:02
@XV-02
Copy link

XV-02 commented Sep 20, 2022 •
edited
Loading

This seems to be breaking hotplug detection on Kudu.
Without this PR, in integrated mode, the attempt to attach a monitor - in this case over mini-displayport - is detected and the prompt to switch to hybrid mode is presented.
With this PR, the prompt is not present.
When I look through the output from journalctl I noticed that system76-power did not report [INFO] HotPlugDetect 2
Perf_Journal.log

What diagnostic output would help to resolve this?

@mmstick
Copy link
Member Author

mmstick commented Sep 20, 2022

It doesn't seem to fix the performance issue, so a different approach will be necessary

@mmstick mmstick closed this Sep 20, 2022
@mmstick mmstick deleted the perf branch September 20, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPU usage increases over time and eventually causes audio to stutter
2 participants
@mmstick @XV-02