Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords search doesn't work perfectly #44

Closed
MrRory opened this issue Oct 22, 2016 · 6 comments
Closed

Keywords search doesn't work perfectly #44

MrRory opened this issue Oct 22, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@MrRory
Copy link

MrRory commented Oct 22, 2016

/movies/1?keywords=Independence%20Day:%20Resurgence doesn't return any results. It's seems it is due to the :.

Oh, and maybe we could add searching for imdb key? Would make other things so much easier :)

@ChrisAlderson
Copy link
Member

I'll remove the special characters when searching then.

For the searching by imdb id we already have:

Or where you thinking along the lines of:

  • /moives/{page}?imdb_id={imdb_id}

@MrRory
Copy link
Author

MrRory commented Oct 22, 2016

Oh that's true ofc. Removing the special chars when searching would work

@ChrisAlderson
Copy link
Member

So the search by imdb id is a non-issue then?

@MrRory
Copy link
Author

MrRory commented Oct 22, 2016

Yep, if everything uses the imdb id's in this API then it's already solved.

@ChrisAlderson
Copy link
Member

The anime series don't use the imdb id, they use an id from HummingBird. I could look into switching the metadata provider from HummingBird to Trakt.tv, but I don't know if Trakt.tv has many anime series in their database.

@MrRory
Copy link
Author

MrRory commented Oct 22, 2016

I was only referring to the movies :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants