Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 6.4.1 to 6.4.2 should have been a major #21

Closed
aramirezj opened this issue Jan 12, 2025 · 1 comment
Closed

Version 6.4.1 to 6.4.2 should have been a major #21

aramirezj opened this issue Jan 12, 2025 · 1 comment
Assignees
Labels
Type: Invalid Doesn't really belong here. Maybe use discussion threads?

Comments

@aramirezj
Copy link

Package version

6.4.2

Describe the bug

Hi! I just wanted to mention, that, due that in the 6.4.2, in the package.json, the change of

"sourcemap: true"

to

"sourcemap: false"

Breaks imports such as import type { Logger } from '@poppinss/cliui'; with a tsconfig with moduleResolution:"node"

It has caused a breaking change in our codebase since we had in our tsconfig, moduleResolution:"node" and that options without the sourcemaps it's not working anymore. So it should have been saved for a major technically.

Reproduction repo

No response

@thetutlage
Copy link
Member

Hello @aramirezj

Can you please share a reproduction for the same. Because the sourcemaps should have no impact on the types, because the index.d.ts file still contains an export for the Logger.

CleanShot 2025-01-13 at 18 04 58@2x

You can verify it directly on npm. https://www.npmjs.com/package/@poppinss/cliui?activeTab=code

@thetutlage thetutlage self-assigned this Jan 13, 2025
@thetutlage thetutlage added the Type: Invalid Doesn't really belong here. Maybe use discussion threads? label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Invalid Doesn't really belong here. Maybe use discussion threads?
Projects
None yet
Development

No branches or pull requests

2 participants