You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! I just wanted to mention, that, due that in the 6.4.2, in the package.json, the change of
"sourcemap: true"
to
"sourcemap: false"
Breaks imports such as import type { Logger } from '@poppinss/cliui'; with a tsconfig with moduleResolution:"node"
It has caused a breaking change in our codebase since we had in our tsconfig, moduleResolution:"node" and that options without the sourcemaps it's not working anymore. So it should have been saved for a major technically.
Reproduction repo
No response
The text was updated successfully, but these errors were encountered:
Can you please share a reproduction for the same. Because the sourcemaps should have no impact on the types, because the index.d.ts file still contains an export for the Logger.
Package version
6.4.2
Describe the bug
Hi! I just wanted to mention, that, due that in the 6.4.2, in the package.json, the change of
"sourcemap: true"
to
"sourcemap: false"
Breaks imports such as
import type { Logger } from '@poppinss/cliui';
with a tsconfig withmoduleResolution:"node"
It has caused a breaking change in our codebase since we had in our tsconfig, moduleResolution:"node" and that options without the sourcemaps it's not working anymore. So it should have been saved for a major technically.
Reproduction repo
No response
The text was updated successfully, but these errors were encountered: