Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out global vars in Node app #28

Open
andrewhao opened this issue Jan 6, 2015 · 1 comment
Open

Factor out global vars in Node app #28

andrewhao opened this issue Jan 6, 2015 · 1 comment

Comments

@andrewhao
Copy link
Member

Stuff like this makes peoples' eyes burn:

State = image_src_list: []

Factor out the global and instead pass it around as inputs to the system.
@andrewhao
Copy link
Member Author

A side effect of this manifested in #34.

Suggest we pass an immutable data object between function calls and callbacks in place of maintaining a global State object.

This was referenced Nov 30, 2015
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewhao