Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with image_compositor.coffee #33

Open
techyteach-s opened this issue Mar 15, 2015 · 4 comments
Open

issue with image_compositor.coffee #33

techyteach-s opened this issue Mar 15, 2015 · 4 comments

Comments

@techyteach-s
Copy link

Hi, I've been getting an error every time I run shmile

  • For context I am running shmile in raspbian on a Raspberry Pi, in general it is working well, however this is a continuing error.

image

Once this error has occurred shmile crashes and has to me restarted.

If anyone has any tips, or ideas as to why this error is happening, please let me know, I've tried to figure it out, but unfortunately my skills and understanding a pretty lacking, so I'm struggling!

@techyteach-s
Copy link
Author

I may have fixed the error, in line 61 of the code for image_compositor.coffee the argument -size seems to be incorrect and should be -resize. When using -size the user has to determine the the width and height, using -resize the user simply needs a percentage. This seems to be working correctly for me, if anyone else can confirm whether or not I am correct that would be great.

@andrewhao
Copy link
Member

@techyteach-s You may be right - the imagemagick version that image_compositor links to is a very specific version that really only worked on my computer. Which version of imagemagick are you using? You can find out by typing convert --version.

@techyteach-s
Copy link
Author

@andrewhao I've had a look and I'm using version 6.7.7-10, and I'd say you're probably right, I believe the change is mainly necessary when using it on a Raspberry Pi, as it works fine on OSX.

@andrewhao
Copy link
Member

@techyteach-s - you're welcome to fix it - I suggest you look into generalizing a method to pass arguments in a more structured way depending on the version number. Or you could just hack it on your fork :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants