fix(performance): allow Synchronizer to be compiled
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stipsan
force-pushed
the
refactor-synchronizer
branch
from
dc3710f to
8e49bea
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves this warning:
Which is thrown because
onFlushPendingPatchesThrottled, wrapped inuseMemo, is callingonFlushPendingPatches(), which is using a reference.This is technically a false negative by the compiler, but seeing that
onFlushPendingPatchesThrottledis only needed and used by a singleuseEffectit makes sense to move it in there anyway, making it obvious to the compiler thatonFlushPendingPatchesThrottledis never called during render and can use anyuseRefinstances safely.Reported to the team here.