fix: prevent double spaces in toPlainText when span follows non-span
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theisel
added a commit
to theisel/astro-portabletext
that referenced
this pull request
Nov 4, 2024
Prevent double spaces in `toPlainText` output (see portabletext/toolkit#93).
theisel
added a commit
to theisel/astro-portabletext
that referenced
this pull request
Nov 4, 2024
Prevent double spaces in `toPlainText` output (see portabletext/toolkit#93).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of an edge case, but this was the intention all along, although a faulty regex prevented this from actually being applied:
When calling
toPlainText()on a block that has a span that ends with a space, then is followed by a non-span, then followed by a span - it currently adds an additional space. It should instead only add one if there is no space between the two spans.