Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for downloading nw.js' Chromedriver #13

Closed
twolfson opened this issue Jul 10, 2015 · 6 comments
Closed

Add support for downloading nw.js' Chromedriver #13

twolfson opened this issue Jul 10, 2015 · 6 comments

Comments

@twolfson
Copy link
Contributor

In nwjs/npm-installer#23, we are discussing what repository best fits downloading nw.js' Chromedriver. It was recently mentioned that Selenium can take a custom path for both Chromedriver binary as well as Chrome binary. Would it be possible to add another download option for nw.js' Chromedriver?

@pose
Copy link
Owner

pose commented Jul 13, 2015

@twolfson Yes, definitely. We can add a new property here called nw-chromedriver: https://github.com/pose/webdriver-manager/blob/master/config.json#L3 . What do you think?

@twolfson
Copy link
Contributor Author

Yea, I think that would work.

@gbmhunter
Copy link

Looks good.

@pose pose closed this as completed in 9d15621 Jul 19, 2015
@twolfson
Copy link
Contributor Author

Awesome, thanks @pose. I will try it right out =)

@twolfson
Copy link
Contributor Author

It looks like the latest release is installing chromedriver instead of chromedriver-nw =/

$ ./node_modules/.bin/webdriver-manager update --chromedriver-nw
Updating selenium standalone
downloading http://selenium-release.storage.googleapis.com/2.46/selenium-server-standalone-2.46.0.jar...
Updating chromedriver
downloading http://chromedriver.storage.googleapis.com/2.16/chromedriver_linux64.zip...
chromedriver_2.16.zip downloaded to /home/todd/github/plaidchat/node_modules/webdriver-manager/selenium/chromedriver_2.16.zip
/home/todd/github/plaidchat/node_modules/webdriver-manager/selenium/chromedriver_2.16.zip /home/todd/github/plaidchat/node_modules/webdriver-manager/selenium
selenium-server-standalone-2.46.0.jar downloaded to /home/todd/github/plaidchat/node_modules/webdriver-manager/selenium/selenium-server-standalone-2.46.0.jar
The following files were installed: /home/todd/github/plaidchat/node_modules/webdriver-manager/selenium/selenium-server-standalone-2.46.0.jar /home/todd/github/plaidchat/node_modules/webdriver-manager/selenium/chromedriver

@twolfson
Copy link
Contributor Author

I found the issue and am opening a patch for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants