-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for downloading nw.js' Chromedriver #13
Comments
@twolfson Yes, definitely. We can add a new property here called |
Yea, I think that would work. |
Looks good. |
Awesome, thanks @pose. I will try it right out =) |
It looks like the latest release is installing $ ./node_modules/.bin/webdriver-manager update --chromedriver-nw
Updating selenium standalone
downloading http://selenium-release.storage.googleapis.com/2.46/selenium-server-standalone-2.46.0.jar...
Updating chromedriver
downloading http://chromedriver.storage.googleapis.com/2.16/chromedriver_linux64.zip...
chromedriver_2.16.zip downloaded to /home/todd/github/plaidchat/node_modules/webdriver-manager/selenium/chromedriver_2.16.zip
/home/todd/github/plaidchat/node_modules/webdriver-manager/selenium/chromedriver_2.16.zip /home/todd/github/plaidchat/node_modules/webdriver-manager/selenium
selenium-server-standalone-2.46.0.jar downloaded to /home/todd/github/plaidchat/node_modules/webdriver-manager/selenium/selenium-server-standalone-2.46.0.jar
The following files were installed: /home/todd/github/plaidchat/node_modules/webdriver-manager/selenium/selenium-server-standalone-2.46.0.jar /home/todd/github/plaidchat/node_modules/webdriver-manager/selenium/chromedriver |
I found the issue and am opening a patch for it. |
In nwjs/npm-installer#23, we are discussing what repository best fits downloading nw.js' Chromedriver. It was recently mentioned that Selenium can take a custom path for both Chromedriver binary as well as Chrome binary. Would it be possible to add another download option for nw.js' Chromedriver?
The text was updated successfully, but these errors were encountered: