Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical bug in trident caused a significant portion of Date_C14_Labnr columns to be filled with wrong values #15

Closed
nevrome opened this issue May 31, 2021 · 0 comments · Fixed by #17

Comments

@nevrome
Copy link
Member

nevrome commented May 31, 2021

A critical bug in trident (poseidon-framework/poseidon-hs@df72486), only now fixed in v.0.17.4, caused the janno columns Date_C14_Labnr to be overwritten by Date_C14_Uncal_BP. Unfortunately this affects a significant portion of all packages in published_data, because they went through trident when we split up the former Reich dataset.

We will have to go through all packages and reintroduce the respective lab numbers.

The most practical approach for that might be to copy the respective entries from the large Boston_datashare janno file we had before b9d0654 into the new janno files. So yet again boring, manual labour. Alternative ideas are very welcome.

We should also check the other janno files not extracted from the Reich dataset. Maybe some of them went through trident as well. Probably the most easy solution for that will be to make the labnr data type in poseidon-hs more specific, so to validate labnrs. They have a specific structure and can be validated accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant