You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
suggestion (general): great-tables' code base is massive, so it's not a surprise that there is a lot going on, maintenance-wise. I'd like to share a tip I've used for a few years to manage my TODOs and FIXMEs throughout code bases. I use the syntax # (): (FIXME, respectively)(you may notice that it's the same "conventional" syntax that I use in this very same review). The idea is that you can quickly extract all the TODOs related to a specific subject. For instance, in _utils.py, in the pairwise function, the comment about Python 3.10 could be # TODO(py310): Remove because part of stdlib. With this one trick, you can easily track down all TODOs and FIXMEs related to Python 3.10.
From the pyOpenSci comment:
suggestion (general): great-tables' code base is massive, so it's not a surprise that there is a lot going on, maintenance-wise. I'd like to share a tip I've used for a few years to manage my TODOs and FIXMEs throughout code bases. I use the syntax # (): (FIXME, respectively)(you may notice that it's the same "conventional" syntax that I use in this very same review). The idea is that you can quickly extract all the TODOs related to a specific subject. For instance, in _utils.py, in the pairwise function, the comment about Python 3.10 could be # TODO(py310): Remove because part of stdlib. With this one trick, you can easily track down all TODOs and FIXMEs related to Python 3.10.
pyOpenSci/software-submission#202 (comment)
The text was updated successfully, but these errors were encountered: