Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember editor choice for .qmd files when navigating away or renaming files #1436

Closed
Tracked by #4858
mine-cetinkaya-rundel opened this issue Sep 28, 2023 · 3 comments
Assignees
Labels
area: quarto Issues related to Quarto category.

Comments

@mine-cetinkaya-rundel
Copy link

Positron Version:

Steps to reproduce the issue:

  1. Open a .qmd file and choose Edit in visual editor.
  2. Navigate to another file and then come back to the original .qmd file. Editor switches to source editor, so Positron doesn't remember that the choice of editor was visual.
  3. Switch back to visual and then rename the file, editor switches to source editor again.

What did you expect to happen?

I expected Positron to remember my choice of editor while the file remains open.

Were there any error messages in the output or Developer Tools console?

No.

@petetronic
Copy link
Collaborator

We'll need to provide an API to the quarto extension to handle this.

@isabelizimm
Copy link
Contributor

isabelizimm commented Oct 31, 2024

These are very similar instructions as #1435 so it would make sense to QA these two issues simultaneously. It's a bit of an extensive process! Let me know if you have questions. It's also NOT related to the Positron build for 2024.11, so does not necessarily need to be prioritized for that release.

  1. Go to https://github.com/quarto-dev/quarto/actions/runs/11618391284/artifacts/2130165489 to download the ZIP file of the quarto extension
  2. Unzip
  3. Open the command palette and select Install from VSIX.
  4. Navigate to and install the .vsix file you unzipped
  5. Navigate to the extensions page and reload extension host. This button appeared for me and I could just click it. If it does NOT appear, you can use Developer: Restart extension host from the Command Palette. Image
  6. create 2 files (the content of the document doesn't really matter here, just the topmatter YAML)

test-1.qmd

---
editor: visual
---

# hello there

test-2.qmd

---
editor: source
---

# hello there

The editor selection in yaml should be respected. You should be able to navigate away and back to each file and the editor stays the same.

  1. Manually change the visual editor to source mode. Navigate away from the file and then back. It should stay in source mode.

Image

@testlabauto
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.11.0-140
OS Version          : OSX

Test scenario(s)

Followed validation instructions... looks great!

Link(s) to TestRail test cases run or created:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: quarto Issues related to Quarto category.
Projects
None yet
Development

No branches or pull requests

6 participants