Support for page load detection, title display, navigation commands, etc. in the Viewer on Posit Workbench #4276
Labels
area: run app
area: viewer
Issues related to Viewer category.
area: workbench
Issues related to Workbench category.
Milestone
Currently, the Viewer pane uses Electron APIs to inject a bunch of window message handlers into every page that loads in the Viewer. You can find a writeup of how this works in this PR: #3430
You can find the full set of handlers we inject in this file: https://github.com/posit-dev/positron/blob/main/src/vs/workbench/contrib/webview/browser/pre/webview-events.js
Without these handlers, the Viewer pane functionality is significantly impaired. In particular:
For example, here's where we guess that the load time of the page is 500ms, because we don't have a way to know otherwise.
positron/src/vs/workbench/contrib/positronPreview/browser/previewOverlayWebview.ts
Lines 86 to 96 in de62b4e
Since we are injecting the handlers using Electron APIs, they are not injected in Posit Workbench. In order to achieve parity with the desktop experience, we need to get them injected somehow (or recreate the functionality in some other way). Some ideas:
The text was updated successfully, but these errors were encountered: