Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing spacebar with delete confirmation modal is generating duplicate modals #4765

Closed
petetronic opened this issue Sep 19, 2024 · 3 comments
Assignees
Labels
area: ui Issues related to UI category. area: variables Issues related to Variables category.

Comments

@petetronic
Copy link
Collaborator

System details:

Positron and OS details:

Positron Version: 2024.09.0 (Universal) build 45

Interpreter details:

Any runtime should do

Describe the issue:

Pressing the spacebar while the modal is open from the Delete all objects option in the Variables pane seems to create a duplicate modal dialog.

Steps to reproduce the issue:

  1. Create any variable in any runtime so there is an entry in the Variables Pane
  2. Click the Delete all objects button
  3. While the modal is open, press the spacebar multiple times
  4. Note the modal does not close, and the app background gets dimmer each time
  5. Press the Cancel button, note the app background gets lighter each time

Expected or desired behavior:

Perhaps that the default action would be selected, per the request in #383, or do nothing.

Were there any error messages in the UI, Output panel, or Developer Tools console?

No, the issue may be the Delete all objects button still has focus, and the spacebar is triggering a duplicate modal each time?

@petetronic
Copy link
Collaborator Author

Screenshot 2024-09-19 at 5 29 27 PM

@petetronic petetronic added area: variables Issues related to Variables category. area: ui Issues related to UI category. labels Sep 19, 2024
@petetronic petetronic added this to the Release Candidate milestone Sep 23, 2024
@softwarenerd softwarenerd self-assigned this Sep 24, 2024
@softwarenerd
Copy link
Contributor

This is addressed in: #4807.

@testlabauto
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.09.0-95
OS Version          : OSX

Test scenario(s)

Cannot repro according to filing description

Link(s) to TestRail test cases run or created:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: ui Issues related to UI category. area: variables Issues related to Variables category.
Projects
None yet
Development

No branches or pull requests

3 participants