Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node.js 0.12 support #27

Closed
ai opened this issue Oct 12, 2016 · 10 comments
Closed

node.js 0.12 support #27

ai opened this issue Oct 12, 2016 · 10 comments

Comments

@ai
Copy link
Member

ai commented Oct 12, 2016

Right now postcss-loader falls on node.js 0.12 with:

Error: /home/travis/build/postcss/postcss-loader/node_modules/postcss-load-config/index.js:7
const config = require('cosmiconfig')
^^^^^
Use of const in strict mode.

I know that we could ignore node.js 0.12, but fix will be so small. I think it is better to support it in this case. Anyway we have a lot of users on 0.12.

@ai
Copy link
Member Author

ai commented Oct 12, 2016

Also we may need to test other postcss-load-* packages.

@michael-ciniawsky
Copy link
Collaborator

yep, I dropped node v0.12 support, bc of cosmiconfig a similiar 'issue'. If cosmiconfig is open to suppprt node v0.12, I fixed it of course. Either babel preinstall/prepublish hook or back to var then.

@ai
Copy link
Member Author

ai commented Oct 13, 2016

@DavidClark You dropped node.js 0.12 support only for const?

OK, I could drop node.js 0.12 support in postcss-loader. But I think we should care about users more, than about functional-style trends.

@michael-ciniawsky
Copy link
Collaborator

@ai Yep, basically agreed, but on the other hand node v0.12 support ends Jan 2017 :), it's a bit early to drop it nevertheless, I can ask/check if webpack 2 release will be node v4+ anyways.

@ai
Copy link
Member Author

ai commented Oct 13, 2016

Ok. Good point.

@michael-ciniawsky
Copy link
Collaborator

@ai so you are fine with dropping node v0.12 it for now ? In case that many users start complaining about it, I prepare/keep track of adding node v0.12 back on both cosmiconfig && postcss-load-config, it should be trivial :)

@ai
Copy link
Member Author

ai commented Oct 13, 2016

You convinced me about node.JS 0.12 support, but I remembered other problem.

When we integrate config to core, const will fall Safari (even if config code will not be executed in browser).

So we need to fix it. I will create issue in comsiconf.

@ai ai reopened this Oct 13, 2016
@ai
Copy link
Member Author

ai commented Oct 13, 2016

Comsiconf issue: cosmiconfig/cosmiconfig#35

@ai
Copy link
Member Author

ai commented Oct 14, 2016

@michael-ciniawsky Cosmiconfig fixed node.js 0.12 support ;)

@michael-ciniawsky
Copy link
Collaborator

michael-ciniawsky commented Oct 14, 2016

@ai 👍
@DavidClark Thx for reverting to node v0.12 && comsiconfig in general, appreciated :+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants