Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from pickle to json for persistence #14

Closed
4 tasks
fritzo opened this issue Jul 13, 2017 · 1 comment
Closed
4 tasks

Switch from pickle to json for persistence #14

fritzo opened this issue Jul 13, 2017 · 1 comment
Assignees
@fritzo
Labels
cleanup enhancement

Comments

@fritzo
Copy link
Member

fritzo commented Jul 13, 2017

Why?

How?

  • Add a dependency on simplejson.
  • Add class <--> json wraper functions json_dump and json_load in treecat.format'. These need to handle numpy.ndarrays and TreeStructure` objects.
  • Add an open_compressed wrapper function so we can use gzip compression.
  • Replace pickle_* functions with json_* everywhere.
@fritzo fritzo self-assigned this Jul 13, 2017
@fritzo
Copy link
Member Author

fritzo commented Jul 14, 2017

Fixed by #15

@fritzo fritzo closed this as completed Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fritzo fritzo

Labels
cleanup enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fritzo