Skip to content

tag container with release tags #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeoLeung opened this issue Jun 20, 2023 · 6 comments
Open

tag container with release tags #484

DeoLeung opened this issue Jun 20, 2023 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@DeoLeung
Copy link

Hi,

It will be better if the container could be tagged using the release tags,
it will be much more easy to find target versions.

@levkk levkk added enhancement New feature or request help wanted Extra attention is needed labels Jun 20, 2023
@sebastianwebber
Copy link
Contributor

@levkk what do you think about pushing the builds only in the main tag and all tags?

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-branches-and-tags

the config in build-and-push.yaml will be something like this:

# ...
on:
  push:
    branches:    
      - main
    tags:
      - v*

Let me know if you agree so I can send another PR.

@levkk
Copy link
Contributor

levkk commented Jul 14, 2023

That works I think.

@sebastianwebber
Copy link
Contributor

there we go: #508

@sebastianwebber
Copy link
Contributor

Before closing this issue, do you think that it will be nice to add a goreleaser config file to automatically generate a release when a new tag is created?

@sebastianwebber
Copy link
Contributor

@levkk I noticed that you merged my PR. It worked for the main branch, is the case to create a new tag to validate it? Something like v1.0.1 should work.

@levkk
Copy link
Contributor

levkk commented Jul 15, 2023

Will test it out as soon as I can release the next version. Probably early next week, we're overdue for a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants