Skip to content

Commit 17c2d28

Browse files
committed
Simplify moc test handling in Makefile
Remove has_explain_summary since it's only relevant with PG 9.x; move all the if(USE_HEALPIX) sections into one.
1 parent 1366e73 commit 17c2d28

File tree

1 file changed

+2
-15
lines changed

1 file changed

+2
-15
lines changed

Makefile

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -38,18 +38,10 @@ REGRESS = init tables points euler circle line ellipse poly path box index \
3838
contains_ops contains_ops_compat bounding_box_gist gnomo epochprop \
3939
contains overlaps spoint_brin sbox_brin
4040

41-
ifneq ($(USE_HEALPIX),0)
42-
REGRESS += healpix moc mocautocast
43-
endif
44-
4541
TESTS = init_test tables points euler circle line ellipse poly path box \
4642
index contains_ops contains_ops_compat bounding_box_gist gnomo \
4743
epochprop contains overlaps spoint_brin sbox_brin
4844

49-
ifneq ($(USE_HEALPIX),0)
50-
TESTS += healpix moc mocautocast
51-
endif
52-
5345
PG_CFLAGS += -DPGSPHERE_VERSION=$(PGSPHERE_VERSION)
5446
PG_CPPFLAGS += -DPGSPHERE_VERSION=$(PGSPHERE_VERSION)
5547

@@ -70,6 +62,8 @@ PGS_SQL = pgs_types.sql pgs_point.sql pgs_euler.sql pgs_circle.sql \
7062
pgs_gist.sql gnomo.sql pgs_brin.sql
7163

7264
ifneq ($(USE_HEALPIX),0)
65+
REGRESS += healpix moc moc1 moc100 mocautocast
66+
TESTS += healpix moc moc1 moc100 mocautocast
7367
PGS_SQL += healpix.sql
7468
endif
7569

@@ -109,17 +103,10 @@ healpix_bare/healpix_bare.o : healpix_bare/healpix_bare.c
109103
$(COMPILE.c) -Wno-declaration-after-statement -o $@ $^
110104

111105
pg_version := $(word 2,$(shell $(PG_CONFIG) --version))
112-
has_explain_summary = $(if $(filter-out 9.%,$(pg_version)),y,n)
113106

114107
crushtest: REGRESS += $(CRUSH_TESTS)
115108
crushtest: installcheck
116109

117-
ifneq ($(USE_HEALPIX),0)
118-
ifeq ($(has_explain_summary),y)
119-
REGRESS += moc1 moc100
120-
endif
121-
endif
122-
123110
test: pg_sphere.test.sql
124111
$(pg_regress_installcheck) --temp-instance=tmp_check $(REGRESS_OPTS) $(TESTS)
125112

0 commit comments

Comments
 (0)