Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical Bug: Uncaught exception thrown in posthtml-match-helper due to pseudo selectors #15

Closed
titanism opened this issue Feb 10, 2023 · 1 comment

Comments

@titanism
Copy link

titanism commented Feb 10, 2023

You need to strip pseudo selectors before passing them to posthtml-match-helper.

Otherwise an uncaught exception is thrown, because that package creates a new RegExp instance whereas the string has unescaped ) and ( parenthesis.

See posthtml/posthtml-match-helper#8.

@titanism
Copy link
Author

Ignore the above - we don't need to inline CSS anymore, since a majority of clients now support it, so we're dropping inline CSS support in our work. Thank you though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant