fix: ignore hidden and non .js files in loader (#113)

* fix: ignore hidden and non .js files in loader (#110)

* style: renaming variables for consistentcy

* refactor: export `isJSFile` helper straight from `fs` package

* refactor: import isJSFile from fs instead

src/packages/fs/index.js

@@ -5,3 +5,4 @@ import { promisifyAll } from 'bluebird';
 promisifyAll(fs);
 
 export default fs;
+export isJSFile from './utils/is-js-file';

src/packages/fs/utils/is-js-file.js

@@ -0,0 +1,4 @@
+// filter out hidden files && non .js files
+export default function isJSFile(file) {
+  return /^(?!\.).+\.js$/.test(file);
+}

src/packages/loader/index.js

@@ -1,4 +1,4 @@
-import fs from '../fs';
+import fs, { isJSFile } from '../fs';
 
 export default async function loader(appPath, type) {
   if (type === 'routes') {
@@ -8,6 +8,7 @@ export default async function loader(appPath, type) {
   } else {
     return new Map(
       (await fs.readdirAsync(`${appPath}/app/${type}`))
+        .filter(isJSFile)
         .map(file => {
           return [
             file.replace('.js', ''),

test/unit/packages/fs.js

@@ -0,0 +1,34 @@
+import { expect } from 'chai';
+
+import { isJSFile } from '../../../src/packages/fs';
+
+describe('Unit: class fs ', () => {
+  describe('Unit: util isJSFile', () => {
+    const subject = {
+      a: 'author.js',
+      b: '.gitkeep',
+      c: 'author.js~'
+    };
+
+    it('is a JavaScript file', () => {
+      const result = isJSFile(subject.a);
+
+      expect(result).to.be.a('boolean');
+      expect(result).to.equal(true);
+    });
+
+    it('filter out hidden files', () => {
+      const result = isJSFile(subject.b);
+
+      expect(result).to.be.a('boolean');
+      expect(result).to.equal(false);
+    });
+
+    it('filter out non JavaScript files', () => {
+      const result = isJSFile(subject.c);
+
+      expect(result).to.be.a('boolean');
+      expect(result).to.equal(false);
+    });
+  });
+});