refactor: remove response stream in favor of res.end() (#225)

* refactor: remove response stream in favor of res.end()

* refactor: responder should return a curried function

Author: zacharygolba

README.md

@@ -20,7 +20,6 @@ This isn't another wrapper around [Express](http://expressjs.com/) or a framewor
 * Automatic pagination, sorting, filtering via query params in controllers
 * CLI for eliminating boiler plate
 * [JSON API](http://jsonapi.org/) 1.0 compliant out of the box
-* Chunked/Streamed JSON responses to client over http
 * Optimized database queries based on serialized attributes and associations
 * Highly extensible - just write reusable JavaScript functions
 * Pairs nicely with client-side JavaScript applications 🍷

src/packages/server/index.js

@@ -2,7 +2,7 @@
 import http from 'http';
 import { parse as parseURL } from 'url';
 
-import responder from './responder';
+import { createResponder } from './responder';
 
 import entries from '../../utils/entries';
 import tryCatch from '../../utils/try-catch';
@@ -70,6 +70,7 @@ class Server {
 
   receiveRequest(req: IncomingMessage, res: ServerResponse): void {
     const startTime = Date.now();
+    const respond = createResponder(req, res);
 
     tryCatch(async () => {
       const { logger } = this;
@@ -108,22 +109,8 @@ class Server {
         startTime
       });
 
-      this.sendResponse(req, res, await this.router.visit(req, res));
-    }, err => {
-      this.sendResponse(req, res, err);
-    });
-  }
-
-  sendResponse(
-    req: IncomingMessage,
-    res: ServerResponse,
-    data: void | ?mixed
-  ): void {
-    if (data && typeof data.pipe === 'function') {
-      data.pipe(res);
-    } else {
-      responder.resolve(req, res, data);
-    }
+      respond(await this.router.visit(req, res));
+    }, respond);
   }
 }
 

src/packages/server/responder/index.js

@@ -1,30 +1,26 @@
 // @flow
-import Response from './response';
-
 import normalize from './utils/normalize';
 
 import type { IncomingMessage, ServerResponse } from 'http';
 
-export function resolve(
+export function createResponder(
   req: IncomingMessage,
-  res: ServerResponse,
-  data: ?mixed | void
-): void {
-  new Response()
-    .once('ready', (stream: Response) => {
-      const { normalized, ...meta } = normalize(data);
-      let { statusCode } = meta;
+  res: ServerResponse
+): (data: ?mixed | void) => void {
+  return function respond(data: ?mixed | void): void {
+    const { normalized, ...meta } = normalize(data);
+    let { statusCode } = meta;
 
-      if (statusCode === 200 && req.method === 'POST') {
-        statusCode++;
-      }
+    if (statusCode === 200 && req.method === 'POST') {
+      statusCode++;
+    }
 
-      res.statusCode = statusCode;
-      stream.end(normalized);
-    })
-    .pipe(res);
-}
+    res.statusCode = statusCode;
 
-export default {
-  resolve
-};
+    if (typeof normalized === 'string') {
+      res.end(normalized);
+    } else {
+      res.end(JSON.stringify(normalized));
+    }
+  };
+}