fix: migration generator indexes (#625)

* Fix generator so it does not create a single index over id, created_at, updated_at but separate indexes. * Generate separate indices Don't generate index for id (covered by PRIMARY already) * Update example & test app migrations with correct indexes
postlight · Jan 16, 2017 · ebbcf57 · ebbcf57
1 parent 93aa5c4
commit ebbcf57
Show file tree

Hide file tree

Showing 22 changed files with 44 additions and 32 deletions.
diff --git a/examples/social-network/db/migrate/2016051621371582-create-users.js b/examples/social-network/db/migrate/2016051621371582-create-users.js
@@ -15,7 +15,8 @@ export function up(schema) {
       .notNullable();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/examples/social-network/db/migrate/2016051621393305-create-actions.js b/examples/social-network/db/migrate/2016051621393305-create-actions.js
@@ -11,7 +11,8 @@ export function up(schema) {
       .notNullable();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/examples/social-network/db/migrate/2016051621405358-create-comments.js b/examples/social-network/db/migrate/2016051621405358-create-comments.js
@@ -17,7 +17,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/examples/social-network/db/migrate/2016051621421145-create-reactions.js b/examples/social-network/db/migrate/2016051621421145-create-reactions.js
@@ -20,7 +20,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/examples/social-network/db/migrate/2016051621434009-create-posts.js b/examples/social-network/db/migrate/2016051621434009-create-posts.js
@@ -18,7 +18,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/examples/social-network/db/migrate/2016051621435837-create-friendships.js b/examples/social-network/db/migrate/2016051621435837-create-friendships.js
@@ -9,7 +9,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/examples/social-network/db/migrate/2016051621460053-create-notifications.js b/examples/social-network/db/migrate/2016051621460053-create-notifications.js
@@ -14,7 +14,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/examples/social-network/db/migrate/2016061214092135-create-tags.js b/examples/social-network/db/migrate/2016061214092135-create-tags.js
@@ -7,7 +7,8 @@ export function up(schema) {
       .notNullable();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/examples/social-network/db/migrate/2016061214112168-create-categorizations.js b/examples/social-network/db/migrate/2016061214112168-create-categorizations.js
@@ -9,7 +9,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/examples/todo/db/migrate/2016051617272695-create-tasks.js b/examples/todo/db/migrate/2016051617272695-create-tasks.js
@@ -17,10 +17,8 @@ export function up(schema) {
     table.integer('list_id').index();
 
     table.timestamps();
-    table.index([
-      'created_at',
-      'updated_at'
-    ]);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/examples/todo/db/migrate/2016051617273905-create-lists.js b/examples/todo/db/migrate/2016051617273905-create-lists.js
@@ -8,10 +8,8 @@ export function up(schema) {
       .notNullable();
 
     table.timestamps();
-    table.index([
-      'created_at',
-      'updated_at'
-    ]);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/src/packages/cli/templates/model-migration.js b/src/packages/cli/templates/model-migration.js
@@ -58,11 +58,8 @@ export default (name: string, attrs: Array<string> | string): string => {
         ${body}
         table.timestamps();
 
-        table.index([
-          'id',
-          'created_at',
-          'updated_at'
-        ]);
+        table.index('created_at');
+        table.index('updated_at');
       });
     }
 

diff --git a/test/test-app/db/migrate/2016051621371582-create-users.js b/test/test-app/db/migrate/2016051621371582-create-users.js
@@ -15,7 +15,8 @@ export function up(schema) {
       .notNullable();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/test/test-app/db/migrate/2016051621393305-create-actions.js b/test/test-app/db/migrate/2016051621393305-create-actions.js
@@ -11,7 +11,8 @@ export function up(schema) {
       .notNullable();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/test/test-app/db/migrate/2016051621405358-create-comments.js b/test/test-app/db/migrate/2016051621405358-create-comments.js
@@ -17,7 +17,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/test/test-app/db/migrate/2016051621421145-create-reactions.js b/test/test-app/db/migrate/2016051621421145-create-reactions.js
@@ -22,7 +22,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/test/test-app/db/migrate/2016051621434009-create-posts.js b/test/test-app/db/migrate/2016051621434009-create-posts.js
@@ -18,7 +18,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/test/test-app/db/migrate/2016051621435837-create-friendships.js b/test/test-app/db/migrate/2016051621435837-create-friendships.js
@@ -9,7 +9,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/test/test-app/db/migrate/2016051621460053-create-notifications.js b/test/test-app/db/migrate/2016051621460053-create-notifications.js
@@ -14,7 +14,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/test/test-app/db/migrate/2016061214092135-create-tags.js b/test/test-app/db/migrate/2016061214092135-create-tags.js
@@ -7,7 +7,8 @@ export function up(schema) {
       .notNullable();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/test/test-app/db/migrate/2016061214112168-create-categorizations.js b/test/test-app/db/migrate/2016061214112168-create-categorizations.js
@@ -9,7 +9,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }
 

diff --git a/test/test-app/db/migrate/2016092015442134-create-images.js b/test/test-app/db/migrate/2016092015442134-create-images.js
@@ -12,7 +12,8 @@ export function up(schema) {
       .index();
 
     table.timestamps();
-    table.index(['created_at', 'updated_at']);
+    table.index('created_at');
+    table.index('updated_at');
   });
 }