-
Notifications
You must be signed in to change notification settings - Fork 453
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* feat: fortune parser For some reason, the dek doesn’t appear in the local version of the article I selected. I tried parsing the meta tag containing og:description but it’s not working, and the description is slightly longer than the dek in the original article. I’m not sure why, but for the lead image, the meta tag for og:image is not parsing the image url. :( * feat: fortune redesigned, so re-did extractor * fix: added timezone
- Loading branch information
1 parent
c133ddf
commit ad29acd
Showing
4 changed files
with
137 additions
and
0 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
export const FortuneComExtractor = { | ||
domain: 'fortune.com', | ||
|
||
title: { | ||
selectors: [ | ||
'h1', | ||
], | ||
}, | ||
|
||
author: { | ||
selectors: [ | ||
['meta[name="author"]', 'value'], | ||
], | ||
}, | ||
|
||
date_published: { | ||
selectors: [ | ||
'.MblGHNMJ', | ||
], | ||
|
||
timezone: 'UTC', | ||
}, | ||
|
||
lead_image_url: { | ||
selectors: [ | ||
['meta[name="og:image"]', 'value'], | ||
], | ||
}, | ||
|
||
content: { | ||
selectors: [ | ||
['picture', 'article.row'], | ||
'article.row', | ||
], | ||
|
||
// Is there anything in the content you selected that needs transformed | ||
// before it's consumable content? E.g., unusual lazy loaded images | ||
transforms: { | ||
}, | ||
|
||
// Is there anything that is in the result that shouldn't be? | ||
// The clean selectors will remove anything that matches from | ||
// the result | ||
clean: [ | ||
|
||
], | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
import assert from 'assert'; | ||
import fs from 'fs'; | ||
import URL from 'url'; | ||
import cheerio from 'cheerio'; | ||
|
||
import Mercury from 'mercury'; | ||
import getExtractor from 'extractors/get-extractor'; | ||
import { excerptContent } from 'utils/text'; | ||
|
||
describe('FortuneComExtractor', () => { | ||
describe('initial test case', () => { | ||
let result; | ||
let url; | ||
beforeAll(() => { | ||
url = | ||
'http://fortune.com/2016/12/15/amazon-alexa-gadgets/'; | ||
const html = | ||
fs.readFileSync('./fixtures/fortune.com/1485216994169.html'); | ||
result = | ||
Mercury.parse(url, html, { fallback: false }); | ||
}); | ||
|
||
it('is selected properly', () => { | ||
// This test should be passing by default. | ||
// It sanity checks that the correct parser | ||
// is being selected for URLs from this domain | ||
const extractor = getExtractor(url); | ||
assert.equal(extractor.domain, URL.parse(url).hostname); | ||
}); | ||
|
||
it('returns the title', async () => { | ||
// To pass this test, fill out the title selector | ||
// in ./src/extractors/custom/fortune.com/index.js. | ||
const { title } = await result; | ||
|
||
// Update these values with the expected values from | ||
// the article. | ||
assert.equal(title, 'Here Are 6 Can’t-Miss Gadgets Powered by Amazon’s Alexa Assistant'); | ||
}); | ||
|
||
it('returns the author', async () => { | ||
// To pass this test, fill out the author selector | ||
// in ./src/extractors/custom/fortune.com/index.js. | ||
const { author } = await result; | ||
|
||
// Update these values with the expected values from | ||
// the article. | ||
assert.equal(author, 'John Patrick Pullen, TIME'); | ||
}); | ||
|
||
it('returns the date_published', async () => { | ||
// To pass this test, fill out the date_published selector | ||
// in ./src/extractors/custom/fortune.com/index.js. | ||
const { date_published } = await result; | ||
|
||
// Update these values with the expected values from | ||
// the article. | ||
assert.equal(date_published, '2016-12-15T14:57:00.000Z'); | ||
}); | ||
|
||
it('returns the lead_image_url', async () => { | ||
// To pass this test, fill out the lead_image_url selector | ||
// in ./src/extractors/custom/fortune.com/index.js. | ||
const { lead_image_url } = await result; | ||
|
||
// Update these values with the expected values from | ||
// the article. | ||
assert.equal(lead_image_url, 'https://fortunedotcom.files.wordpress.com/2016/05/amazon-echo-2.jpg?w=720'); | ||
}); | ||
|
||
it('returns the content', async () => { | ||
// To pass this test, fill out the content selector | ||
// in ./src/extractors/custom/fortune.com/index.js. | ||
// You may also want to make use of the clean and transform | ||
// options. | ||
const { content } = await result; | ||
|
||
const $ = cheerio.load(content || ''); | ||
|
||
const first13 = excerptContent($('*').first().text(), 13); | ||
|
||
// Update these values with the expected values from | ||
// the article. | ||
assert.equal(first13, 'The Amazon Echo Dot, the retailer’s puck-shaped smart speaker, is is killing it'); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters