Skip to content

Commit

Permalink
feat: thepennyhoarder parser (#112)
Browse files Browse the repository at this point in the history
* feat: thepennyhoarder parser

Looks good, although no image in preview!

* fix: adds selector for article lead image
  • Loading branch information
janetleekim authored and dviramontes committed Feb 3, 2017
1 parent fadd198 commit bf29291
Show file tree
Hide file tree
Showing 4 changed files with 135 additions and 0 deletions.
1 change: 1 addition & 0 deletions fixtures/www.thepennyhoarder.com/1482509014877.html

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/extractors/custom/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export * from './uproxx.com';
export * from './www.eonline.com';
export * from './www.miamiherald.com';
export * from './www.refinery29.com';
export * from './www.thepennyhoarder.com';
export * from './fusion.net';
export * from './www.americanow.com';
export * from './sciencefly.com';
Expand Down
46 changes: 46 additions & 0 deletions src/extractors/custom/www.thepennyhoarder.com/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
export const WwwThepennyhoarderComExtractor = {
domain: 'www.thepennyhoarder.com',

title: {
selectors: [
['meta[name="dcterms.title"]', 'value'],
],
},

author: {
selectors: [
['link[rel="author"]', 'title'],
],
},

date_published: {
selectors: [
['meta[name="article:published_time"]', 'value'],
],
},

lead_image_url: {
selectors: [
['meta[name="og:image"]', 'value'],
],
},

content: {
selectors: [
['.post-img', '.post-text'],
'.post-text',
],

// Is there anything in the content you selected that needs transformed
// before it's consumable content? E.g., unusual lazy loaded images
transforms: {
},

// Is there anything that is in the result that shouldn't be?
// The clean selectors will remove anything that matches from
// the result
clean: [

],
},
};
87 changes: 87 additions & 0 deletions src/extractors/custom/www.thepennyhoarder.com/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
import assert from 'assert';
import fs from 'fs';
import URL from 'url';
import cheerio from 'cheerio';

import Mercury from 'mercury';
import getExtractor from 'extractors/get-extractor';
import { excerptContent } from 'utils/text';

describe('WwwThepennyhoarderComExtractor', () => {
describe('initial test case', () => {
let result;
let url;
beforeAll(() => {
url =
'http://www.thepennyhoarder.com/find-hidden-cash/';
const html =
fs.readFileSync('./fixtures/www.thepennyhoarder.com/1482509014877.html');
result =
Mercury.parse(url, html, { fallback: false });
});

it('is selected properly', () => {
// This test should be passing by default.
// It sanity checks that the correct parser
// is being selected for URLs from this domain
const extractor = getExtractor(url);
assert.equal(extractor.domain, URL.parse(url).hostname);
});

it('returns the title', async () => {
// To pass this test, fill out the title selector
// in ./src/extractors/custom/www.thepennyhoarder.com/index.js.
const { title } = await result;

// Update these values with the expected values from
// the article.
assert.equal(title, '7 Unexpected Places You Could Find Cash and Valuables Around Your House');
});

it('returns the author', async () => {
// To pass this test, fill out the author selector
// in ./src/extractors/custom/www.thepennyhoarder.com/index.js.
const { author } = await result;

// Update these values with the expected values from
// the article.
assert.equal(author, 'Steve Gillman');
});

it('returns the date_published', async () => {
// To pass this test, fill out the date_published selector
// in ./src/extractors/custom/www.thepennyhoarder.com/index.js.
const { date_published } = await result;

// Update these values with the expected values from
// the article.
assert.equal(date_published, '2016-12-22T13:10:00.000Z');
});

it('returns the lead_image_url', async () => {
// To pass this test, fill out the lead_image_url selector
// in ./src/extractors/custom/www.thepennyhoarder.com/index.js.
const { lead_image_url } = await result;

// Update these values with the expected values from
// the article.
assert.equal(lead_image_url, 'http://cdn.thepennyhoarder.com/wp-content/uploads/2014/07/02170000/Mike-Schmidt-under-Creative-Commons-1024x679.jpg');
});

it('returns the content', async () => {
// To pass this test, fill out the content selector
// in ./src/extractors/custom/www.thepennyhoarder.com/index.js.
// You may also want to make use of the clean and transform
// options.
const { content } = await result;

const $ = cheerio.load(content || '');

const first13 = excerptContent($('*').first().text(), 13);

// Update these values with the expected values from
// the article.
assert.equal(first13, 'While most people associate treasure hunting with pirates, Penny Hoarders know better. There’s');
});
});
});

0 comments on commit bf29291

Please sign in to comment.