Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update methods should have Partial<DefinitionType> type #1277

Open
ThePlenkov opened this issue Jun 23, 2022 · 1 comment
Open

Update methods should have Partial<DefinitionType> type #1277

ThePlenkov opened this issue Jun 23, 2022 · 1 comment

Comments

@ThePlenkov
Copy link

ThePlenkov commented Jun 23, 2022

Hi!

When I call any update method like for example for request:

image

Typescript now asks me to provide all the fields, which is not the way you designed of course.

So intead of this line

update(options: Request.definition): void;

i would suggest to have something like this

update(options: Partial<Request.definition>): void;

will solve the problem entirely.

However I'm not sure how you guys build this file, manually or with some tool too , that's why don't create MR yet.

Thanks!

@pnk-ltoc-892
Copy link

Could you explain how can i test this on my side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants