-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use feature gates #177
Labels
Milestone
Comments
blt
changed the title
Put Lua programmable filters behind a feature gate
Use feature gates
May 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Lua is an obligatory dependency of cernan as of this writing. Not all cernan deployments will wish to use the lua programmable filters but still pay the build-time cost for this. Similar story for firehose – which pulls in rusuto – and any of the other sinks.
We should go all-in on feature flags. There are two issues with doing so. First is configuration. As of this writing we'll have to do macro hacks to get our configuration parsing under control. Second is matrix testing cernan across its features. Integration tests are not able to toggle features.
The text was updated successfully, but these errors were encountered: