Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cancelling merged pull requests #13

Open
potiuk opened this issue Jan 11, 2021 · 5 comments
Open

Support cancelling merged pull requests #13

potiuk opened this issue Jan 11, 2021 · 5 comments

Comments

@potiuk
Copy link
Owner

potiuk commented Jan 11, 2021

It would be great to add an option for cancelling pull request actions for already merged pull requests.

It happens sometimes that you can decide to merge a PR without waiting for the action to complete. Actions for such merged PRs can be safely cancelled.

@potiuk
Copy link
Owner Author

potiuk commented Jan 11, 2021

cc: @TobKed @mik-laj @kaxil @ashb -> yet another optimization we can add to the cancel action (And use in Airflow).

PRs are most welcome :) - I have other stuff to do in the next few days and might not be able to implement it quickly.

@kaxil
Copy link

kaxil commented Jan 11, 2021

I assumed they get cancelled 🤔 but may be not!

@ashb
Copy link

ashb commented Jan 11, 2021

I'm working on self hosted runners, so won't get to it this week

@potiuk
Copy link
Owner Author

potiuk commented Jan 11, 2021

No - they are not. There is no mechanism for that. I often cancel them manually :(

@kaxil
Copy link

kaxil commented Jan 11, 2021

No - they are not. There is no mechanism for that. I often cancel them manually :(

Yea -- If some jobs have not started yet -- then because the checkout action fails since there is no Branch (again assuming that branch is deleted) it gets cancelled.

But the ones that have started will keep on running -- so yeah good call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants