Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to use on non-windows systems? #40

Open
themightyoarfish opened this issue Nov 26, 2022 · 7 comments
Open

Possible to use on non-windows systems? #40

themightyoarfish opened this issue Nov 26, 2022 · 7 comments

Comments

@themightyoarfish
Copy link

Seeing this is electron-based, it should be possible to run on any system. Attempting to npm install on macos errors because the electron release url is incorrect: https://github.com/electron/electron/releases/download/v7.0.1/electron-v7.0.1-darwin-arm64.zip

which I assume would affect all other systems also?

@m-schuetz
Copy link
Collaborator

m-schuetz commented Nov 26, 2022

Works on windows. "darwin-arm64" seems to be mac specific, not sure how and where this is generated. Maybe you could try to update the electron version to the latest version in package.json. Maybe the required builds didn't exist with the old vesion of electron?

@m-schuetz
Copy link
Collaborator

m-schuetz commented Nov 26, 2022

Yeah, only x64 but no arm builds of electron 7.0.1 for darwin/mac: https://github.com/electron/electron/releases/tag/v7.0.1

@themightyoarfish
Copy link
Author

I put in the latest version instead, after which npm install succeeds, but npm run start opens an empty application. Too bad.

image

@themightyoarfish
Copy link
Author

Not much interesting logging

> npm run start

> potree_desktop@1.7.0 start
> electron .

objc[7410]: Class WebSwapCGLLayer is implemented in both /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks/libANGLE-shared.dylib (0x2282ddb50) and /Users/rasmus/Downloads/source_builds/PotreeDesktop/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libGLESv2.dylib (0x108ea6978). One of the two will be used. Which one is undefined.

@m-schuetz
Copy link
Collaborator

Any error messages in the electron/chrome dev tools? (ctrl+shift+i on windows, or view->toggle developer tools)

@raycaster08
Copy link

It doesn't work on Macs, because PotreeConverter is built on the windows platform. You can't run .exe on a mac. I am trying to perfect the electron build on different platforms.

@raycaster08
Copy link

raycaster08 commented Feb 23, 2023

#31 (comment)

The main reason it won't work on m1 is that it won't run PotreeConverter.exe on windows platform. I added a PotreeConverter compiled for the mac m1 platform to the repo and it ran successfully

$ git clone https://github.com/yurui01/PotreeDesktop.git
$ cd PotreeDesktop
$ npm install
$ electron .
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants