Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade declarations to Laravel 5.2 #16

Closed
imagra opened this issue Dec 25, 2015 · 2 comments
Closed

upgrade declarations to Laravel 5.2 #16

imagra opened this issue Dec 25, 2015 · 2 comments

Comments

@imagra
Copy link

imagra commented Dec 25, 2015

By trying to upgrade to L5.2 artisan clear-compiled returns errors like this

Declaration of Potsky\LaravelLocalizationHelpers\Commands\LocalizationAbstract::info() 
should be compatible with Illuminate\Console\Command::info($string, $verbosity = NULL) 

The errors can be fixed by changing declarations to:

public function line( $s , $style = NULL, $verbosity = NULL) {...
public function info( $s ,  $verbosity = NULL) {...
public function comment( $s , $verbosity = NULL ) {...
public function question( $s , $verbosity = NULL) {...
@imagra imagra changed the title upgrade declaration of info to Laravel 5.2 upgrade declarations to Laravel 5.2 Dec 25, 2015
@potsky
Copy link
Owner

potsky commented Dec 25, 2015

Hi,

I have just released blind version 1.3.2 with a fix without any possibility to test during holidays. Could you tell me if problem is resolved now?

@imagra
Copy link
Author

imagra commented Dec 25, 2015

Thank you, there are no errors now with 1.3.2

@potsky potsky closed this as completed Dec 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants