Fix compilation warnings with mix format --migrate

See: https://elixir-lang.org/blog/2024/12/19/elixir-v1-18-0-released/#mix-format---migrate

Author: sgerrand

config/config.exs

@@ -1,5 +1,5 @@
 import Config
 
-if Mix.env == :test do
+if Mix.env() == :test do
   import_config "test.exs"
 end

lib/mix/pow_assent.ex

@@ -8,16 +8,26 @@ defmodule Mix.PowAssent do
   def validate_schema_args!([schema, plural | _rest] = args, task) do
     cond do
       not schema_valid?(schema) ->
-        raise_invalid_schema_args_error!("Expected the schema argument, #{inspect schema}, to be a valid module name", task)
+        raise_invalid_schema_args_error!(
+          "Expected the schema argument, #{inspect(schema)}, to be a valid module name",
+          task
+        )
+
       not plural_valid?(plural) ->
-        raise_invalid_schema_args_error!("Expected the plural argument, #{inspect plural}, to be all lowercase using snake_case convention", task)
+        raise_invalid_schema_args_error!(
+          "Expected the plural argument, #{inspect(plural)}, to be all lowercase using snake_case convention",
+          task
+        )
+
       true ->
         schema_options_from_args(args)
     end
   end
+
   def validate_schema_args!([_schema | _rest], task) do
     raise_invalid_schema_args_error!("Invalid arguments", task)
   end
+
   def validate_schema_args!([], _task), do: schema_options_from_args()
 
   defp schema_valid?(schema), do: schema =~ ~r/^[A-Z]\w*(\.[A-Z]\w*)*$/
@@ -35,6 +45,10 @@ defmodule Mix.PowAssent do
   end
 
   defp schema_options_from_args(_opts \\ [])
-  defp schema_options_from_args([schema, plural | _rest]), do: %{schema_name: schema, schema_plural: plural}
-  defp schema_options_from_args(_any), do: %{schema_name: "UserIdentities.UserIdentity", schema_plural: "user_identities"}
+
+  defp schema_options_from_args([schema, plural | _rest]),
+    do: %{schema_name: schema, schema_plural: plural}
+
+  defp schema_options_from_args(_any),
+    do: %{schema_name: "UserIdentities.UserIdentity", schema_plural: "user_identities"}
 end

lib/mix/tasks/ecto/pow_assent.ecto.gen.migration.ex

@@ -50,10 +50,22 @@ defmodule Mix.Tasks.PowAssent.Ecto.Gen.Migration do
     |> Enum.each(&create_migration_file/1)
   end
 
-  defp create_migration_file(%{repo: repo, binary_id: binary_id, users_table: users_table, schema_plural: schema_plural}) do
-    context_base  = Pow.app_base(Pow.otp_app())
-    schema        = UserIdentitiesMigration.new(context_base, schema_plural, repo: repo, binary_id: binary_id, users_table: users_table)
-    content       = UserIdentitiesMigration.gen(schema)
+  defp create_migration_file(%{
+         repo: repo,
+         binary_id: binary_id,
+         users_table: users_table,
+         schema_plural: schema_plural
+       }) do
+    context_base = Pow.app_base(Pow.otp_app())
+
+    schema =
+      UserIdentitiesMigration.new(context_base, schema_plural,
+        repo: repo,
+        binary_id: binary_id,
+        users_table: users_table
+      )
+
+    content = UserIdentitiesMigration.gen(schema)
 
     Migration.create_migration_file(repo, schema.migration_name, content)
   end

lib/mix/tasks/ecto/pow_assent.ecto.gen.schema.ex

@@ -41,13 +41,15 @@ defmodule Mix.Tasks.PowAssent.Ecto.Gen.Schema do
     |> Map.merge(config)
   end
 
-  defp create_schema_file(%{binary_id: binary_id, schema_name: schema_name, schema_plural: schema_plural} = config) do
-    context_app  = Map.get(config, :context_app) || Pow.otp_app()
+  defp create_schema_file(
+         %{binary_id: binary_id, schema_name: schema_name, schema_plural: schema_plural} = config
+       ) do
+    context_app = Map.get(config, :context_app) || Pow.otp_app()
     context_base = Pow.app_base(context_app)
-    schema       = SchemaModule.new(context_base, schema_name, schema_plural, binary_id: binary_id)
-    content      = SchemaModule.gen(schema)
-    dir_name     = dir_name(schema_name)
-    file_name    = file_name(schema.module)
+    schema = SchemaModule.new(context_base, schema_name, schema_plural, binary_id: binary_id)
+    content = SchemaModule.gen(schema)
+    dir_name = dir_name(schema_name)
+    file_name = file_name(schema.module)
 
     context_app
     |> Pow.context_lib_path(dir_name)
@@ -84,7 +86,7 @@ defmodule Mix.Tasks.PowAssent.Ecto.Gen.Schema do
     |> File.exists?()
     |> case do
       false -> path
-      _     -> Mix.raise("schema file can't be created, there is already a schema file in #{path}.")
+      _ -> Mix.raise("schema file can't be created, there is already a schema file in #{path}.")
     end
   end
 end

lib/mix/tasks/ecto/pow_assent.ecto.install.ex

@@ -51,22 +51,28 @@ defmodule Mix.Tasks.PowAssent.Ecto.Install do
 
     config
   end
+
   defp maybe_run_gen_migration(config, _args), do: config
 
   defp maybe_run_gen_schema(%{schema: true} = config, args) do
     SchemaTask.run(args)
 
     config
   end
+
   defp maybe_run_gen_schema(config, _args), do: config
 
   defp parse_structure(config) do
-    context_app  = Map.get(config, :context_app) || Pow.otp_app()
+    context_app = Map.get(config, :context_app) || Pow.otp_app()
     context_base = Pow.app_base(context_app)
     user_module = Module.concat([context_base, "Users.User"])
     user_file = Path.join(["lib", "#{context_app}", "users", "user.ex"])
 
-    Map.put(config, :structure, %{context_app: context_app, user_module: user_module, user_file: user_file})
+    Map.put(config, :structure, %{
+      context_app: context_app,
+      user_module: user_module,
+      user_file: user_file
+    })
   end
 
   defp print_shell_instructions(%{structure: structure} = config) do
@@ -80,7 +86,7 @@ defmodule Mix.Tasks.PowAssent.Ecto.Install do
         config
 
       :error ->
-        Mix.raise "Couldn't install PowAssent! Did you run this inside your Ecto app?"
+        Mix.raise("Couldn't install PowAssent! Did you run this inside your Ecto app?")
     end
   end
 
@@ -96,17 +102,16 @@ defmodule Mix.Tasks.PowAssent.Ecto.Install do
           needle: "use Pow.Ecto.Schema"
         }
       ],
-      instructions:
-        """
-        Add the `PowAssent.Ecto.Schema` macro to #{Path.relative_to_cwd(file)} after `use Pow.Ecto.Schema`:
+      instructions: """
+      Add the `PowAssent.Ecto.Schema` macro to #{Path.relative_to_cwd(file)} after `use Pow.Ecto.Schema`:
 
-        defmodule #{inspect(structure.user_module)} do
-          use Ecto.Schema
-          use Pow.Ecto.Schema
-          use PowAssent.Ecto.Schema
+      defmodule #{inspect(structure.user_module)} do
+        use Ecto.Schema
+        use Pow.Ecto.Schema
+        use PowAssent.Ecto.Schema
 
-        # ...
-        """
+      # ...
+      """
     }
   end
 end

lib/mix/tasks/phoenix/pow_assent.phoenix.gen.templates.ex

@@ -29,13 +29,13 @@ defmodule Mix.Tasks.PowAssent.Phoenix.Gen.Templates do
   end
 
   @templates [
-    {"registration", ~w(add_user_id)},
+    {"registration", ~w(add_user_id)}
   ]
 
   defp create_template_files({config, _parsed, _invalid}) do
-    structure    = Phoenix.parse_structure(config)
-    web_module   = structure[:web_module]
-    web_prefix   = structure[:web_prefix]
+    structure = Phoenix.parse_structure(config)
+    web_module = structure[:web_module]
+    web_prefix = structure[:web_prefix]
 
     Enum.each(@templates, fn {name, actions} ->
       Phoenix.create_template_module(Elixir.PowAssent, name, web_module, web_prefix)

lib/mix/tasks/phoenix/pow_assent.phoenix.install.ex

@@ -55,7 +55,7 @@ defmodule Mix.Tasks.PowAssent.Phoenix.Install do
         config
 
       :error ->
-        Mix.raise "Couldn't install PowAssent! Did you run this inside your Phoenix app?"
+        Mix.raise("Couldn't install PowAssent! Did you run this inside your Phoenix app?")
     end
   end
 
@@ -111,33 +111,32 @@ defmodule Mix.Tasks.PowAssent.Phoenix.Install do
           needle: "pow_routes()"
         }
       ],
-      instructions:
-        """
-        Update `#{Path.relative_to_cwd(file)}` with the PowAssent routes:
+      instructions: """
+      Update `#{Path.relative_to_cwd(file)}` with the PowAssent routes:
 
-        defmodule #{inspect(structure.web_module)}.Router do
-          use #{inspect(structure.web_module)}, :router
-          use Pow.Phoenix.Router
-        #{router_use_content}
+      defmodule #{inspect(structure.web_module)}.Router do
+        use #{inspect(structure.web_module)}, :router
+        use Pow.Phoenix.Router
+      #{router_use_content}
 
-          # ...
+        # ...
 
-        #{router_pipeline_content}
+      #{router_pipeline_content}
 
-          # ...
+        # ...
 
-        #{router_scope_content}
+      #{router_scope_content}
 
-          scope "/" do
-            pipe_through :browser
-
-            pow_routes()
-        #{router_routes_macro}
-          end
+        scope "/" do
+          pipe_through :browser
 
-          # ...
+          pow_routes()
+      #{router_routes_macro}
         end
-        """
+
+        # ...
+      end
+      """
     }
   end
 
@@ -146,5 +145,6 @@ defmodule Mix.Tasks.PowAssent.Phoenix.Install do
 
     config
   end
+
   defp maybe_run_gen_templates(config, _args), do: config
 end

lib/mix/tasks/pow_assent.install.ex

@@ -37,14 +37,13 @@ defmodule Mix.Tasks.PowAssent.Install do
 
   defp no_umbrella! do
     if Project.umbrella?() do
-      Mix.raise(
-        """
-        mix #{@mix_task} has to be used inside an application directory, but this is an umbrella project.
+      Mix.raise("""
+      mix #{@mix_task} has to be used inside an application directory, but this is an umbrella project.
 
-        Run mix pow_assent.ecto.install inside your Ecto application directory to create schema module and migrations.
+      Run mix pow_assent.ecto.install inside your Ecto application directory to create schema module and migrations.
 
-        Run mix pow_assent.phoenix.install in your Phoenix application directory for configuration instructions.
-        """)
+      Run mix pow_assent.phoenix.install in your Phoenix application directory for configuration instructions.
+      """)
     end
 
     :ok

lib/pow_assent/config.ex

@@ -19,7 +19,7 @@ defmodule PowAssent.Config do
   def get(config, key, default \\ nil) do
     case Keyword.get(config, key, :not_found) do
       :not_found -> get_env_config(config, key, default)
-      value      -> value
+      value -> value
     end
   end
 
@@ -35,7 +35,7 @@ defmodule PowAssent.Config do
     config
     |> Keyword.get(:otp_app)
     |> case do
-      nil     -> Application.get_all_env(env_key)
+      nil -> Application.get_all_env(env_key)
       otp_app -> Application.get_env(otp_app, env_key, [])
     end
     |> Keyword.get(key, default)
@@ -83,6 +83,7 @@ defmodule PowAssent.Config do
       deep_merge(left, right)
     end)
   end
+
   defp deep_merge(_left, right), do: right
 
   @doc """