Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running the layout is not idempotent #289

Open
flo-dup opened this issue Oct 15, 2021 · 3 comments
Open

Running the layout is not idempotent #289

flo-dup opened this issue Oct 15, 2021 · 3 comments
Labels

Comments

@flo-dup
Copy link
Contributor

flo-dup commented Oct 15, 2021

  • Do you want to request a feature or report a bug?
    Bug

  • What is the current behavior?
    Running the layout is not idempotent

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
    Running twice the layout on the same Diagram object leads to ugly glitches (wider cells, floating internal nodes, margins between voltage levels wider, ....)

  • What is the expected behavior?
    Running twice the layout on the same Diagram object leads to the same SVG file

  • What is the motivation / use case for changing the behavior?
    Fixing a bug

  • Please tell us about your environment:
    PowSyBl Version: core 4.4.0 and sld 2.4.0

@flo-dup
Copy link
Contributor Author

flo-dup commented Jan 5, 2022

This does not really occur anymore, as it is not possible to run twice the layout directly with the new SingleLineDiagram interface. Nonetheless, the behaviour is not normal and should be investigated further

@geofjamg
Copy link
Member

geofjamg commented Jan 5, 2022

This does not really occur anymore, as it is not possible to run twice the layout directly with the new SingleLineDiagram interface. Nonetheless, the behaviour is not normal and should be investigated further

But we cannot suppose that everybody will use SingleLineDiagram. This is just a convenient utility class.

@flo-dup
Copy link
Contributor Author

flo-dup commented Jan 5, 2022

Yes, in fact that's what I meant by saying "not really".

@So-Fras So-Fras added the SLD label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants