Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some unit tests fail with JDK17 #295

Closed
geofjamg opened this issue Nov 2, 2021 · 1 comment · Fixed by #296
Closed

Some unit tests fail with JDK17 #295

geofjamg opened this issue Nov 2, 2021 · 1 comment · Fixed by #296
Assignees

Comments

@geofjamg
Copy link
Member

geofjamg commented Nov 2, 2021

  • Do you want to request a feature or report a bug?
    Bug

  • What is the current behavior?
    Unit tests relying on SVG comparison fail when running with Java17.
    A bit of history:

  • before migrating to JDK11, SVG produced (so by JDK8) for CDATA section was:
<svg xmlns="http://www.w3.org/2000/svg">
   <style><![CDATA[
XXXX
]]></style>
  • with JDK11 we got:
<svg xmlns="http://www.w3.org/2000/svg">
    <style>
        <![CDATA[
]]>
    </style>

So additional line breaks are added after and before open and close style tag.

  • What is the expected behavior?
    we want unit test succeed using JDK11 and JDK17

  • What is the motivation / use case for changing the behavior?

  • Please tell us about your environment:

    • PowSyBl Version: ...
    • OS Version: ...
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)

(if a question doesn't apply, you can delete it)

@geofjamg
Copy link
Member Author

geofjamg commented Nov 2, 2021

@flo-dup I propose like explain in the thread to got back to JDK8 formatting and add to regex replace hack to remove extra line breaks added by JDK11.

@flo-dup flo-dup linked a pull request Nov 4, 2021 that will close this issue
5 tasks
@flo-dup flo-dup closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants