You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This unique repository could be named powsybl-diagrams, or @geofjamg suggested keeping the single-line-diagram name.
Indeed, a network-area-diagram could also be seen as a single-line diagram: a diagram with single-line meaning simplification of the three phases/lines into one. Nonetheless, single-line diagram seems to be very commonly used for what is now powsybl-single-line-diagram (diagrams at the voltage level scale). Calling something else single-line diagram might be misleading?
What makes sense to take part of the geographical code in that repo, even though there's no link to it yet: it will be used for the network-area-diagram layout, either as an input of the force layout, or for a geographical layout. Maybe also help the powsybl-single-line-diagram substation and zone layout.
What does not make sense in my opinion: it's strange to have such a generic extension in a repo which brings a lot more and whose name does not indicate it would contain it. Indeed one might need the geo data without wanting any diagram feature That would be a specific artifact of the new repo, but still, I think it makes more sense to have it in powsybl-core.
About the tree of this new repo, it could be divided in
a powsybl-single-line-diagram module if the repo does not take that name, powsybl-voltage-level-diagram otherwise? (do not forget to also rename new SingleLineDiagram class). This module would have as submodules the current powsybl-single-line-diagram modules
a powsybl-network-area-diagram module with the content of current powsybl-network-area-diagram repo
Do you want to request a feature or report a bug?
Refactor
What is the current behavior?
Several repositories are somehow related to each other
What is the expected behavior?
These repositories could be grouped together in a unique repository
What is the motivation / use case for changing the behavior?
Avoid useless multiplication of repos hence releases, group code that works together
The text was updated successfully, but these errors were encountered: