Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigation needed on apparently unnecessary if condition #485

Closed
So-Fras opened this issue Jan 27, 2023 · 0 comments · Fixed by #492
Closed

Investigation needed on apparently unnecessary if condition #485

So-Fras opened this issue Jan 27, 2023 · 0 comments · Fixed by #492
Assignees
Labels
bug Something isn't working SLD

Comments

@So-Fras
Copy link
Member

So-Fras commented Jan 27, 2023

  • Do you want to request a feature or report a bug?
    bug / investigation needed

  • What is the current behavior?
    In SLD, in the PositionFromExtension.java > gatherLayoutExtensionInformation () function, a test on the direction value is added before setting the bus cell direction:

if (direction != Direction.UNDEFINED) {
    bc.setDirection(direction);
}

If this condition is removed, some unit tests fail (there are errors in the drawings of intern cells).
However, this condition should not be necessary as the UNDEFINED value is the default value for direction.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
    In order to reproduce the bug, remove the if condition

  • What is the expected behavior?
    The expected behavior is that the "if condition" is not necessary. Some investigations are needed here to understand if there is an underlying bug.

  • What is the motivation / use case for changing the behavior?
    Cleaner code

  • Please tell us about your environment:

    • PowSyBl Version: 3.0.0
@So-Fras So-Fras added bug Something isn't working SLD labels Jan 27, 2023
@So-Fras So-Fras self-assigned this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SLD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant