Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No clear feedback given to user when referencing a parameter set id not available in dynawaltz inputs parameters files #214

Closed
rosiereflo opened this issue Apr 24, 2023 · 1 comment · Fixed by #233
Labels
bug Something isn't working

Comments

@rosiereflo
Copy link

Describe the current behavior

The user has to provide a parameter file and a parameter id for the network and the solver in the DynaWaltz configuration. When the parameter id is not avaialable in the parameter file powsybl-dynawo goes on without any error or warning.

Describe the expected behavior

A clear error id should appear when the network/solver id is not found in the parameter file

Describe the steps

No response

Environment

No response

Relevant Log Output

No response

Extra Information

No response

@rosiereflo rosiereflo added the bug Something isn't working label Apr 24, 2023
@flo-dup
Copy link
Contributor

flo-dup commented Apr 24, 2023

I'm wondering whether it should be just a log or if we should throw an exception? if dynawo handles en empty parameters set, it should be a log, but if not we could throw an exception instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants