Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppb sprite subclasses cannot be defined in Jupyter notebooks #300

Closed
moshez opened this issue Jul 5, 2019 · 5 comments
Closed

ppb sprite subclasses cannot be defined in Jupyter notebooks #300

moshez opened this issue Jul 5, 2019 · 5 comments

Comments

@moshez
Copy link
Contributor

moshez commented Jul 5, 2019

See notebook at https://github.com/moshez/ppb-issue/blob/master/ppb-issue.ipynb (I cannot attach notebooks to tickets).

Steps to reproduce:

  • Save notebook locally
  • In a virtual environment, install ppb and jupyterlab
  • Run jupyter lab
  • Open the notebook from the browser
  • Execute the cell
@AstraLuma
Copy link
Member

This looks extremely similar to the problem I found with defining sprites in a repl.

This should be fixed incidentally by the asset system rebuild.

@moshez
Copy link
Contributor Author

moshez commented Jul 5, 2019

Is there a ticket opened for the problem you found? Happy to dup this.

@AstraLuma
Copy link
Member

#267 and #270

I'm guessing that jupyter does something slightly different to defeat this.

@moshez
Copy link
Contributor Author

moshez commented Jul 5, 2019

This is fixed by #270 -- I did not update my ppb repository.

@moshez moshez closed this as completed Jul 5, 2019
@AstraLuma
Copy link
Member

Note: #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AstraLuma @moshez