Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DoNotRender #395

Closed
AstraLuma opened this issue Mar 20, 2020 · 0 comments · Fixed by #477
Closed

Remove DoNotRender #395

AstraLuma opened this issue Mar 20, 2020 · 0 comments · Fixed by #477
Labels
new contributor Apply to issues we think can be tackled by people new to PPB

Comments

@AstraLuma
Copy link
Member

The function that DoNotRender provides can just as easily be handled by None

Note that we also have ... (Ellipsis) that can be used to indicate "Please calculate a reasonable default"
@AstraLuma AstraLuma added the new contributor Apply to issues we think can be tackled by people new to PPB label Mar 29, 2020
@AstraLuma AstraLuma mentioned this issue May 22, 2020
Merged
@bors bors bot closed this as completed in 9aab03d May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new contributor Apply to issues we think can be tackled by people new to PPB
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove DoNotRender. AstraLuma/pursuedpybear
1 participant
@AstraLuma