Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with Colors #449

Open
pathunstrom opened this issue Apr 26, 2020 · 3 comments
Open

Working with Colors #449

pathunstrom opened this issue Apr 26, 2020 · 3 comments
Labels
discussion Issues that more just discussing than specific flaws or features enhancement

Comments

@pathunstrom
Copy link
Collaborator

Currently, we expose color APIs pretty directly as RGB tuples. It'd be nice to support multiple color notations.

Personally, I like working with HSV, and have mostly been using an external tool to find my colors and convert them to RGB.

We should do a total pass at all the places we use color and see if we can support other notations.

  • RGB 0-255
  • HSV (There's at least two popular notations for this. Maybe pick one?)
  • Hex codes

Open to other ideas.

@pathunstrom pathunstrom added enhancement discussion Issues that more just discussing than specific flaws or features labels Apr 26, 2020
@ironfroggy
Copy link
Contributor

Would it also be possible to support RGB 0.0-1.0 tuples?

@pathunstrom
Copy link
Collaborator Author

It's not unreasonable.

I'm trying to decide if this is best as a Color interface and a bunch of concrete classes that allow the various top level implementations and output an (r, g, b) Tuple in [0, 255] for all of the low level SDL systems that need it or if it's one class that supports the various interfaces. . .

@AstraLuma
Copy link
Member

My primary concern is students: RGB appears in a lot of places, and most of those are 0-255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Issues that more just discussing than specific flaws or features enhancement
Projects
None yet
Development

No branches or pull requests

3 participants