Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed #388

Closed
vnmabus opened this issue Feb 18, 2022 · 4 comments · Fixed by #389
Closed

Add py.typed #388

vnmabus opened this issue Feb 18, 2022 · 4 comments · Fixed by #389

Comments

@vnmabus
Copy link
Contributor

vnmabus commented Feb 18, 2022

Is your feature request related to a problem? Please describe.
In order for Mypy to use the typing information of this project, you need to include a blank file called py.typed along the code, to comply with PEP 561 (https://www.python.org/dev/peps/pep-0561/). Otherwise Mypy skips this library in the type analysis.

Describe the solution you'd like
Add a blank py.typed file and package it along the code.

@ppizarror
Copy link
Owner

Hi. Can you create a new PR? Does setup.py file must be updated?

@vnmabus
Copy link
Contributor Author

vnmabus commented Feb 18, 2022

No, you don't need to add anything to setup.py, but the file must be in the MANIFEST.in in order for it to be packaged.

@ppizarror
Copy link
Owner

Uploaded to pip!

@vnmabus
Copy link
Contributor Author

vnmabus commented Feb 19, 2022

I can confirm that now it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants