Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file config.h.in should be ignored #428

Open
icegood opened this issue Jun 4, 2023 · 6 comments
Open

file config.h.in should be ignored #428

icegood opened this issue Jun 4, 2023 · 6 comments
Assignees

Comments

@icegood
Copy link

icegood commented Jun 4, 2023

Should it be ignored?
https://github.com/ppp-project/ppp/blob/master/pppd/plugins/pppoe/config.h.in

@Neustradamus
Copy link
Member

@paulusmack, @enaess: Have you seen this issue?

@enaess
Copy link
Contributor

enaess commented Jun 6, 2023

IIRC the config.h is still generated for pppoe. It's a weird project organization where pppoe should probably have its own sub-configure task or be moved to a separate repository. I died on that hill a while back ...

@icegood
Copy link
Author

icegood commented Jun 8, 2023

OK, so we have something in code that autotools are not managed to solve. Could you explain in details what is it, since i'm not familar with autotools deep inside?
BTW, strange decision to move to autotools. I think, cmake would be more convenient in this regard...

@enaess
Copy link
Contributor

enaess commented Jun 8, 2023

@icegood what is the problem you are trying to resolve?

You have many good solutions for building a project, autotools is just one of them. Cmake is mostly a C++ based tool, and mason is another good (and more recent) one. Whichever set of tools we stick with has it's pros/cons, but it was still mile-high better than the hard-coded configure script that was checked in.

@enaess
Copy link
Contributor

enaess commented Jun 8, 2023

It's just that this repository has traditionally been a "mono-repository" where all build dependencies was checked in, in one way or another (e.g. libfreeradius, libatm), then also tried to build individual projects like pppoe-plugin, etc. If I had my way, I'd spin out the pppoe plugin in a separate repository and use autotools (or whatever else deemed good at the time to build the sources).

@Neustradamus
Copy link
Member

@icegood: Have you seen latest comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants