Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--disable-microsoft-extensions requires --disable-peap #433

Open
willyamcts opened this issue Jul 3, 2023 · 6 comments
Open

--disable-microsoft-extensions requires --disable-peap #433

willyamcts opened this issue Jul 3, 2023 · 6 comments
Assignees

Comments

@willyamcts
Copy link

When disable Microsoft Extension is required disable PEAP, both are not dependent correct?

if not using --disable-peap the error happens in compilation:

# ./autogen.sh --prefix=/usr/local/pppd --disable-microsoft-extensions

peap.c: In function ‘peap_init’:
peap.c:522:12: error: ‘struct peap_state’ has no member named ‘chap’
  522 |         psm->chap = chap_find_digest(CHAP_MICROSOFT_V2);
      |            ^~
make[2]: *** [Makefile:1492: pppd-peap.o] Error 1
@Neustradamus
Copy link
Member

@paulusmack, @enaess: Have you seen this ticket?

@enaess
Copy link
Contributor

enaess commented Jul 7, 2023

Right now, the only peap method supported is mschapv2, so yes they are sort of dependent on each other. Technically, in the future they can be disjoint...

@Neustradamus
Copy link
Member

@enaess: Can you look it?

@Neustradamus
Copy link
Member

@enaess: Have you progressed on it?

@enaess
Copy link
Contributor

enaess commented Aug 20, 2024

No progress, we can still ship 2.5.1 without this. People would just need to know, PEAP with CHAPv2 is the only thing that woks right now, and if you disable the CHAP extension, PEAP won't authenticate. However, in the future you could probably use PEAP-PAP or something there alike.

@paulusmack
Copy link
Collaborator

I should add a note to the README about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants