Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add song preview player to "submitted beatmap" contest thumbnails #11208

Open
cl8n opened this issue May 13, 2024 · 1 comment · May be fixed by #11225
Open

Add song preview player to "submitted beatmap" contest thumbnails #11208

cl8n opened this issue May 13, 2024 · 1 comment · May be fixed by #11225
Labels
area:contests proposal type:behavioural

Comments

@cl8n
Copy link
Member

cl8n commented May 13, 2024 •
edited
Loading

I'd also want the thumbnails to play the song preview to be consistent with beatmap and featured artist listing behavior.

Originally posted by @Joehuu in #10673 (comment)

depends on the main issue of #10673 being resolved, or else nothing links to the actual map anymore. I'm opening a separate issue for this because it seems slightly more involved and isn't addressed by the PR open for that issue
@Exotica0122
Copy link
Contributor

There is a TrackPreview that renders based on the entry option. Just need to render the TrackPreview with a cover image url instead of the icon that links to the beatmap once the main issue #10673 is resolved

@Exotica0122 Exotica0122 linked a pull request May 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:contests proposal type:behavioural
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add song preview to contest entry for submitted beatmap Exotica0122/osu-web
2 participants
@cl8n @Exotica0122