Merge pull request #22310 from peppy/fix-threading-tournament-save

peppy · web-flow · commit 2a9b1ea9fca4 · 2023-01-21T15:31:56.000+09:00
Fix incorrect async continuation causing tournament client to not enable save button
diff --git a/osu.Game.Tournament/SaveChangesOverlay.cs b/osu.Game.Tournament/SaveChangesOverlay.cs
@@ -70,7 +70,7 @@ protected override void LoadComplete()
 
         private async Task checkForChanges()
         {
-            string serialisedLadder = await Task.Run(() => tournamentGame.GetSerialisedLadder()).ConfigureAwait(false);
+            string serialisedLadder = await Task.Run(() => tournamentGame.GetSerialisedLadder()).ConfigureAwait(true);
 
             // If a save hasn't been triggered by the user yet, populate the initial value
             lastSerialisedLadder ??= serialisedLadder;

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ protected override void LoadComplete()`
`70`	`70`
`71`	`71`	`private async Task checkForChanges()`
`72`	`72`	`{`
`73`		`- string serialisedLadder = await Task.Run(() => tournamentGame.GetSerialisedLadder()).ConfigureAwait(false);`
	`73`	`+ string serialisedLadder = await Task.Run(() => tournamentGame.GetSerialisedLadder()).ConfigureAwait(true);`
`74`	`74`
`75`	`75`	`// If a save hasn't been triggered by the user yet, populate the initial value`
`76`	`76`	`lastSerialisedLadder ??= serialisedLadder;`